Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add ASF basic config #6174

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add ASF basic config

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3baeb49) 48.92% compared to head (de6f23f) 48.95%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6174      +/-   ##
============================================
+ Coverage     48.92%   48.95%   +0.02%     
- Complexity     4765     4781      +16     
============================================
  Files           913      915       +2     
  Lines         31700    31865     +165     
  Branches       3827     3847      +20     
============================================
+ Hits          15510    15600      +90     
- Misses        14647    14704      +57     
- Partials       1543     1561      +18     
Files Coverage Δ
...overy/registry/redis/RedisRegistryServiceImpl.java 63.80% <64.70%> (ø)

... and 5 files with indirect coverage changes

@slievrly slievrly added this to the 2.1.0 milestone Dec 21, 2023
@funky-eyes funky-eyes merged commit 97b9ad9 into apache:2.x Dec 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants