optimize: update source header #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6176 +/- ##
============================================
- Coverage 48.94% 48.94% -0.01%
+ Complexity 4774 4768 -6
============================================
Files 913 913
Lines 31697 31700 +3
Branches 3823 3827 +4
============================================
Hits 15514 15514
- Misses 14639 14644 +5
+ Partials 1544 1542 -2
|
funky-eyes
reviewed
Dec 21, 2023
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| Licensed to the Apache Software Foundation (ASF) under one or more |
There was a problem hiding this comment.
copyright-owner: Seata.io Is that right?
There was a problem hiding this comment.
thanks for review, I have fixed it.
slievrly
commented
Dec 21, 2023
There was a problem hiding this comment.
Evaluate the impact of the post-merge and open PRs. From what we can see, there shouldn't be any conflicts. Newly added files will require header modifications; otherwise, the license header might not pass. Additionally, the license header is not strictly enforced, which theoretically means it could still be merged even if it doesn't pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
update source header
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews