Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: update NOTICE file #6184

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Dec 21, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Update NOTICE file to meet ASF requirements

Ⅱ. Does this pull request fix one issue?

fixes #6183

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 21, 2023
@xingfudeshi xingfudeshi changed the title Update NOTICE file to meet ASF requirements Update NOTICE file Dec 21, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7f5f82) 48.96% compared to head (490c864) 48.96%.

❗ Current head 490c864 differs from pull request most recent head 98946e6. Consider uploading reports for the commit 98946e6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6184   +/-   ##
=========================================
  Coverage     48.96%   48.96%           
+ Complexity     4778     4777    -1     
=========================================
  Files           915      915           
  Lines         31890    31890           
  Branches       3853     3853           
=========================================
  Hits          15614    15614           
  Misses        14715    14715           
  Partials       1561     1561           

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title Update NOTICE file optimize: update NOTICE file Dec 21, 2023
@funky-eyes funky-eyes merged commit f63b29d into apache:2.x Dec 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NOTICE file
4 participants