Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove the useless file #6192

Merged
merged 5 commits into from
Dec 23, 2023
Merged

Conversation

lightClouds917
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove:the duplicate header

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a58770) 48.99% compared to head (5e399c0) 48.99%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6192   +/-   ##
=========================================
  Coverage     48.99%   48.99%           
+ Complexity     4782     4781    -1     
=========================================
  Files           915      915           
  Lines         31892    31892           
  Branches       3853     3853           
=========================================
  Hits          15624    15624           
+ Misses        14706    14705    -1     
- Partials       1562     1563    +1     

see 2 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file has been entirely commented out. I suggest we just delete it.

@lightClouds917 lightClouds917 changed the title optimize:remove the duplicate header delete:remove the useless file Dec 21, 2023
@lightClouds917 lightClouds917 changed the title delete:remove the useless file optimize: remove the useless file Dec 21, 2023
@lightClouds917
Copy link
Contributor Author

It looks like this file has been entirely commented out. I suggest we just delete it.

ok,i will delete it

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我不理解为何要单独提pr删除该无用文件,而不是提交一份将相关测试用例完善的pr来去除这个无效文件?
I don't understand why I need to mention PR to delete this useless file separately, instead of submitting a PR that perfects the relevant test cases to remove this invalid file?

@lightClouds917
Copy link
Contributor Author

lightClouds917 commented Dec 22, 2023

我不理解为何要单独提pr删除该无用文件,而不是提交一份将相关测试用例完善的pr来去除这个无效文件? I don't understand why I need to mention PR to delete this useless file separately, instead of submitting a PR that perfects the relevant test cases to remove this invalid file?

This pr has nothing to do with test cases ,it is intended to completely clean up the outdated license headers in the project, which is the point. After this pr, there is no “Copyright 1999-2019 Seata.io Group."

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit e590de5 into apache:2.x Dec 23, 2023
6 checks passed
@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants