Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: update the url in change log to apache/incubator-seata #6195

Merged
merged 4 commits into from
Dec 23, 2023

Conversation

laywin
Copy link
Contributor

@laywin laywin commented Dec 22, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize change log url

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes
funky-eyes previously approved these changes Dec 22, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laywin laywin changed the title optimize change log url optimize: update change log url Dec 22, 2023
@laywin laywin changed the title optimize: update change log url optimize: update the url in change log to apache/incubator-seata Dec 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a58770) 48.99% compared to head (d50de59) 48.99%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6195   +/-   ##
=========================================
  Coverage     48.99%   48.99%           
+ Complexity     4782     4779    -3     
=========================================
  Files           915      915           
  Lines         31892    31892           
  Branches       3853     3853           
=========================================
+ Hits          15624    15625    +1     
- Misses        14706    14707    +1     
+ Partials       1562     1560    -2     

see 5 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 5690fc7 into apache:2.x Dec 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants