-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize:remove Seata-Docker link #6218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6218 +/- ##
============================================
- Coverage 49.04% 48.97% -0.07%
+ Complexity 4786 4779 -7
============================================
Files 915 915
Lines 31896 31896
Branches 3855 3855
============================================
- Hits 15644 15622 -22
- Misses 14697 14715 +18
- Partials 1555 1559 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- https://github.com/apache/incubator-seata/pull/6218/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L143 need to be remove.
- https://github.com/apache/incubator-seata/pull/6218/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L150 need to be remove.
Ⅰ. Describe what this PR did
Remove Seata-Docker link
Ⅱ. Does this pull request fix one issue?
fixes #6217
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews