Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize links in the console header #6243

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

liuqiufeng
Copy link
Contributor

@liuqiufeng liuqiufeng commented Jan 5, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

优化控制台页眉中的链接
optimize links in the console header

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@liuqiufeng liuqiufeng changed the title optimize: optimize console header urls optimize: optimize links in the console header Jan 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2363715) 49.97% compared to head (7ebe553) 49.91%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6243      +/-   ##
============================================
- Coverage     49.97%   49.91%   -0.06%     
+ Complexity     4928     4926       -2     
============================================
  Files           915      915              
  Lines         31927    31927              
  Branches       3855     3855              
============================================
- Hits          15954    15937      -17     
- Misses        14406    14422      +16     
- Partials       1567     1568       +1     

see 6 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 26feac2 into apache:2.x Jan 5, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants