Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: increase seata-core module unit test coverage #6250

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

lightClouds917
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize: increase seata-core module unit test coverage

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (01e6f0c) 49.86% compared to head (95d54bf) 50.38%.
Report is 2 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6250      +/-   ##
============================================
+ Coverage     49.86%   50.38%   +0.52%     
- Complexity     4932     5035     +103     
============================================
  Files           917      917              
  Lines         31996    32010      +14     
  Branches       3862     3862              
============================================
+ Hits          15954    16129     +175     
+ Misses        14482    14315     -167     
- Partials       1560     1566       +6     
Files Coverage Δ
.../io/seata/core/rpc/netty/v1/ProtocolV1Encoder.java 5.12% <ø> (ø)
.../rm/datasource/exec/BaseTransactionalExecutor.java 74.00% <100.00%> (+0.26%) ⬆️
.../seata/rm/datasource/exec/MultiUpdateExecutor.java 80.26% <100.00%> (+0.26%) ⬆️
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 84.09% <100.00%> (+0.36%) ⬆️
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 78.48% <100.00%> (+0.13%) ⬆️
.../java/io/seata/sqlparser/druid/BaseRecognizer.java 80.95% <ø> (ø)
...a/sqlparser/druid/oracle/BaseOracleRecognizer.java 35.29% <ø> (ø)
...ser/druid/postgresql/BasePostgresqlRecognizer.java 23.21% <ø> (ø)
...arser/druid/sqlserver/BaseSqlServerRecognizer.java 54.54% <ø> (ø)
...ec/mysql/MySQLInsertOnDuplicateUpdateExecutor.java 32.16% <0.00%> (-0.17%) ⬇️
... and 3 more

... and 18 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 77bfc08 into apache:2.x Jan 11, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants