Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement new saga designer #6280

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Conversation

ptyin
Copy link
Member

@ptyin ptyin commented Jan 22, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Since the original framework of Saga designer is no longer maintained. We implement a brand new Saga designer. For more details, please refer to README.md or README-zh.md

Ⅱ. Does this pull request fix one issue?

fixes #5691

@ptyin ptyin linked an issue Jan 22, 2024 that may be closed by this pull request
5 tasks
ptyin added 4 commits January 22, 2024 10:59
# Conflicts:
#	saga/seata-saga-statemachine-designer/LICENSE
#	saga/seata-saga-statemachine-designer/README.md
#	saga/seata-saga-statemachine-designer/README.zh-CN.md
#	saga/seata-saga-statemachine-designer/package.json
#	saga/seata-saga-statemachine-designer/src/components/EditorDetailPanel/DetailForm.js
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec73332) 51.11% compared to head (5a8c6ee) 51.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6280   +/-   ##
=========================================
  Coverage     51.11%   51.11%           
+ Complexity     5101     5099    -2     
=========================================
  Files           918      918           
  Lines         32038    32038           
  Branches       3866     3866           
=========================================
  Hits          16377    16377           
- Misses        14080    14084    +4     
+ Partials       1581     1577    -4     

see 6 files with indirect coverage changes

@ptyin ptyin linked an issue Jan 23, 2024 that may be closed by this pull request
@ptyin ptyin linked an issue Jan 23, 2024 that may be closed by this pull request
7 tasks
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit e858228 into apache:2.x Jan 23, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment