-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: implement new saga designer #6280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
# Conflicts: # saga/seata-saga-statemachine-designer/LICENSE # saga/seata-saga-statemachine-designer/README.md # saga/seata-saga-statemachine-designer/README.zh-CN.md # saga/seata-saga-statemachine-designer/package.json # saga/seata-saga-statemachine-designer/src/components/EditorDetailPanel/DetailForm.js
ptyin
force-pushed
the
refactor_designer
branch
from
January 23, 2024 06:26
fa04235
to
50005fc
Compare
# Conflicts: # saga/seata-saga-statemachine-designer/package-lock.json
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6280 +/- ##
=========================================
Coverage 51.11% 51.11%
+ Complexity 5101 5099 -2
=========================================
Files 918 918
Lines 32038 32038
Branches 3866 3866
=========================================
Hits 16377 16377
- Misses 14080 14084 +4
+ Partials 1581 1577 -4 |
7 tasks
slievrly
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Since the original framework of Saga designer is no longer maintained. We implement a brand new Saga designer. For more details, please refer to README.md or README-zh.md
Ⅱ. Does this pull request fix one issue?
fixes #5691