Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:optimize time query conditions in the console #6285

Merged
merged 17 commits into from
Jan 30, 2024

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Jan 22, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6272

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've already tested file mode and database mode locally
image

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly
Copy link
Member

some UT failed.

@xingfudeshi xingfudeshi changed the title bugfix:fix time query conditions in the console (WIP)bugfix:fix time query conditions in the console Jan 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (7227cc1) 51.95% compared to head (e096030) 51.93%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6285      +/-   ##
============================================
- Coverage     51.95%   51.93%   -0.03%     
+ Complexity     5174     5170       -4     
============================================
  Files           918      918              
  Lines         32039    32045       +6     
  Branches       3866     3866              
============================================
- Hits          16647    16643       -4     
- Misses        13767    13776       +9     
- Partials       1625     1626       +1     
Files Coverage Δ
...onsole/impl/file/GlobalSessionFileServiceImpl.java 82.35% <50.00%> (ø)
...r/console/impl/file/GlobalLockFileServiceImpl.java 90.24% <0.00%> (-7.32%) ⬇️
...erver/console/impl/db/GlobalLockDBServiceImpl.java 0.00% <0.00%> (ø)
...er/console/impl/db/GlobalSessionDBServiceImpl.java 0.00% <0.00%> (ø)
...in/java/org/apache/seata/common/util/PageUtil.java 45.71% <0.00%> (-9.46%) ⬇️

... and 3 files with indirect coverage changes

@xingfudeshi xingfudeshi changed the title (WIP)bugfix:fix time query conditions in the console bugfix:fix time query conditions in the console Jan 24, 2024
@xingfudeshi xingfudeshi changed the title bugfix:fix time query conditions in the console optimize:optimize time query conditions in the console Jan 24, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
In terms of function, this actually belongs to bugfix.

@slievrly slievrly merged commit ee6f660 into apache:2.x Jan 30, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 30, 2024
@xingfudeshi
Copy link
Member Author

LGTM In terms of function, this actually belongs to bugfix.

ok

ptyin pushed a commit to ptyin/seata that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata 控制台查询事务列表接口 时间筛选无效
3 participants