Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: split the frontend resource build process into separate profiles #6294

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

liuqiufeng
Copy link
Contributor

@liuqiufeng liuqiufeng commented Jan 24, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6292

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80482ee) 30.08% compared to head (272f3f1) 30.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6294      +/-   ##
============================================
+ Coverage     30.08%   30.11%   +0.02%     
- Complexity     5436     5441       +5     
============================================
  Files           930      930              
  Lines         60222    60222              
  Branches       7121     7121              
============================================
+ Hits          18119    18137      +18     
+ Misses        40209    40194      -15     
+ Partials       1894     1891       -3     

see 4 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 24, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit fa76fd1 into apache:2.x Jan 25, 2024
6 checks passed
@liuqiufeng liuqiufeng deleted the 2.x_frontend_build_profile branch January 29, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot skip npm packaging
4 participants