Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix problem of maven-pmd-plugin #6297

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Jan 24, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

bugfix: fix problem of maven-pmd-plugin

  1. 修复PMD规范问题;
  2. PMD插件的 check 功能,从 verify 阶段提前到 validate 阶段执行;且默认禁用该插件;
  3. build.yml 中,启用 PMD 校验。

Ⅱ. Does this pull request fix one issue?

fixes #6293

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-transactional functional defects, please use the prefix "optimize".

@slievrly slievrly changed the title bugfix: fix problem of maven-pmd-plugin optimize: fix problem of maven-pmd-plugin Jan 24, 2024
@wangliang181230
Copy link
Contributor Author

For non-transactional functional defects, please use the prefix "optimize".

OK.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 65ee819 into apache:2.x Jan 24, 2024
5 checks passed
@wangliang181230 wangliang181230 deleted the fix-pmd branch January 25, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enumeration of [Role] fields missing comment information
4 participants