Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: repackage name to org.apache.seata #6298

Merged
merged 14 commits into from
Jan 25, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

repackage name to org.apache.seata

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36e6e41) 51.06% compared to head (86adedb) 29.61%.
Report is 3 commits behind head on 2.x.

❗ Current head 86adedb differs from pull request most recent head 7a0cc91. Consider uploading reports for the commit 7a0cc91 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                2.x    #6298       +/-   ##
=============================================
- Coverage     51.06%   29.61%   -21.45%     
- Complexity     5095     5361      +266     
=============================================
  Files           918      930       +12     
  Lines         32038    60222    +28184     
  Branches       3866     7121     +3255     
=============================================
+ Hits          16361    17837     +1476     
- Misses        14096    40534    +26438     
- Partials       1581     1851      +270     
Files Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...c/main/java/org/apache/seata/common/Constants.java 100.00% <ø> (ø)
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...java/org/apache/seata/common/LockStrategyMode.java 0.00% <ø> (ø)
...mon/src/main/java/org/apache/seata/common/XID.java 92.30% <ø> (ø)
...ommon/exception/AuthenticationFailedException.java 100.00% <ø> (ø)
...he/seata/common/exception/DataAccessException.java 100.00% <ø> (ø)
...eata/common/exception/EurekaRegistryException.java 100.00% <ø> (ø)
...che/seata/common/exception/FrameworkErrorCode.java 94.44% <ø> (ø)
...che/seata/common/exception/FrameworkException.java 85.18% <ø> (ø)
... and 88 more

... and 1652 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -644,7 +644,8 @@
<createDependencyReducedPom>true</createDependencyReducedPom>
<artifactSet>
<includes>
<include>io.seata:*</include>
<include>org.apache.seata:*</include>
<include>io.seata:seata-all</include>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在无法确定io.seata:seata-all这个依赖会存在,需要现在就增加相关配置吗?
Can't be sure that the dependency io.seata:seata-all will exist now, do I need to add the relevant configuration now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the subsequent PRs, you will see the corresponding compatibility packaging solutions.

@funky-eyes
Copy link
Contributor

image
测试通过

@slievrly slievrly merged commit 80482ee into apache:2.x Jan 25, 2024
16 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 25, 2024
@slievrly slievrly mentioned this pull request Jan 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants