-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: repackage name to org.apache.seata #6298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6298 +/- ##
=============================================
- Coverage 51.06% 29.61% -21.45%
- Complexity 5095 5361 +266
=============================================
Files 918 930 +12
Lines 32038 60222 +28184
Branches 3866 7121 +3255
=============================================
+ Hits 16361 17837 +1476
- Misses 14096 40534 +26438
- Partials 1581 1851 +270
|
86adedb
to
7a0cc91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -644,7 +644,8 @@ | |||
<createDependencyReducedPom>true</createDependencyReducedPom> | |||
<artifactSet> | |||
<includes> | |||
<include>io.seata:*</include> | |||
<include>org.apache.seata:*</include> | |||
<include>io.seata:seata-all</include> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在无法确定io.seata:seata-all这个依赖会存在,需要现在就增加相关配置吗?
Can't be sure that the dependency io.seata:seata-all will exist now, do I need to add the relevant configuration now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the subsequent PRs, you will see the corresponding compatibility packaging solutions.
Ⅰ. Describe what this PR did
repackage name to org.apache.seata
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews