optimize: add io.seata package shade #6302
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6302 +/- ##
============================================
- Coverage 51.05% 51.02% -0.04%
Complexity 5263 5263
============================================
Files 934 934
Lines 33026 33026
Branches 4002 4002
============================================
- Hits 16862 16852 -10
- Misses 14496 14508 +12
+ Partials 1668 1666 -2 |
compatible/pom.xml
Outdated
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| <dependencies> | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <groupId>org.apache.seata</groupId> | |||
There was a problem hiding this comment.
如果他不依赖org.apache.seata:seata-all,会影响应用使用吗?假设我使用一个io.seata:seata-all 2.1.0-SNAPSHOT
If he doesn't depend on org.apache.seata:seata-all, will it affect the application usage? Let's say I use an io.seata:seata-all 2.1.0-SNAPSHOT
There was a problem hiding this comment.
In my judgment, if the compatible module doesn't depend on org.apache.seata:seata-all, then it's not complete and users will have problems using it because of the missing classes. If he's missing classes, what's the difference between that and just using io.seata:seata-all and typing a version specifically to be used as a usedby tag?
根据我的判断，如果兼容模块不依赖于org. apache.seata：seata-all，那么它就不完整，用户会因为缺少类而在使用它时遇到问题。如果他缺少类，这与仅使用io.seata：seata-all并输入专门用作usedby标记的版本有什么区别？
There was a problem hiding this comment.
io.seata:seata-all won't release module package.
|
|
Ⅰ. Describe what this PR did
add io.seata package shade
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews