Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: server compatible io.seata package #6310

Merged
merged 33 commits into from
Jan 30, 2024
Merged

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

changes/zh-cn/2.x.md Outdated Show resolved Hide resolved
changes/en-us/2.x.md Outdated Show resolved Hide resolved
@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7227cc1) 51.95% compared to head (bfcb186) 52.10%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6310      +/-   ##
============================================
+ Coverage     51.95%   52.10%   +0.14%     
- Complexity     5174     5202      +28     
============================================
  Files           918      921       +3     
  Lines         32039    32134      +95     
  Branches       3866     3869       +3     
============================================
+ Hits          16647    16744      +97     
+ Misses        13767    13764       -3     
- Partials       1625     1626       +1     
Files Coverage Δ
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...che/seata/common/exception/JsonParseException.java 100.00% <ø> (ø)
.../org/apache/seata/common/metadata/ClusterRole.java 100.00% <ø> (ø)
...ava/org/apache/seata/common/metadata/Metadata.java 100.00% <ø> (ø)
...apache/seata/common/metadata/MetadataResponse.java 80.00% <ø> (ø)
...in/java/org/apache/seata/common/metadata/Node.java 100.00% <ø> (ø)
...java/org/apache/seata/common/util/ConfigTools.java 100.00% <ø> (ø)
...ava/org/apache/seata/common/util/DurationUtil.java 83.33% <ø> (ø)
...a/org/apache/seata/common/util/HttpClientUtil.java 52.45% <ø> (+4.91%) ⬆️
...main/java/org/apache/seata/common/util/IOUtil.java 70.00% <ø> (ø)
... and 103 more

... and 111 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ptyin ptyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it more appropriate to put the deprecated classes in the "compatible" folder?

@funky-eyes
Copy link
Contributor Author

Is it more appropriate to put the deprecated classes in the "compatible" folder?

This is the server-side class, not the client-side, and moving it into compatible will cause the server to rely on unnecessary classes unless a server-compatible is added.
这是server侧的类,而不是client侧,如果移入compatible中会导致server依赖一些不必要的类,除非增加一个server-compatible

@ptyin
Copy link
Member

ptyin commented Jan 29, 2024

Is it more appropriate to put the deprecated classes in the "compatible" folder?

This is the server-side class, not the client-side, and moving it into compatible will cause the server to rely on unnecessary classes unless a server-compatible is added. 这是server侧的类,而不是client侧,如果移入compatible中会导致server依赖一些不必要的类,除非增加一个server-compatible

Uhhhh, my bad. I forgot this is the server module.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 5a84c42 into apache:2.x Jan 30, 2024
6 checks passed
ptyin pushed a commit to ptyin/seata that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants