Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: console display the version number #6313

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

liuqiufeng
Copy link
Contributor

@liuqiufeng liuqiufeng commented Jan 29, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

image

Ⅱ. Does this pull request fix one issue?

fixes #6240

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

# Conflicts:
#	console/src/main/resources/static/console-fe/.gitignore
#	console/src/main/resources/static/console-fe/build/webpack.base.conf.js
#	console/src/main/resources/static/css/main.css
#	console/src/main/resources/static/js/main.js
#	console/src/main/resources/static/saga-statemachine-designer/dist/bundle.js
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7227cc1) 51.95% compared to head (f3188d6) 51.91%.

❗ Current head f3188d6 differs from pull request most recent head 6b6d488. Consider uploading reports for the commit 6b6d488 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6313      +/-   ##
============================================
- Coverage     51.95%   51.91%   -0.05%     
+ Complexity     5174     5167       -7     
============================================
  Files           918      918              
  Lines         32039    32039              
  Branches       3866     3866              
============================================
- Hits          16647    16633      -14     
- Misses        13767    13783      +16     
+ Partials       1625     1623       -2     

see 11 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 16689ad into apache:2.x Jan 29, 2024
6 checks passed
@liuqiufeng liuqiufeng deleted the 2.x_console_version_num branch January 29, 2024 06:19
@slievrly slievrly added this to the 2.1.0 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The console needs to display the version number
5 participants