Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: compatible with integration.http and integration.http.Jakarta #6327

Merged
merged 11 commits into from
Feb 15, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Feb 4, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

compatible with integration.http

Ⅱ. Does this pull request fix one issue?

compatible with integration.http

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title optimize: compatible with integration.http optimize: compatible with integration.http and integration.http.Jakarta Feb 4, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84c9f35) 51.96% compared to head (098a314) 51.95%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6327      +/-   ##
============================================
- Coverage     51.96%   51.95%   -0.01%     
+ Complexity     5188     5183       -5     
============================================
  Files           921      921              
  Lines         32166    32166              
  Branches       3874     3874              
============================================
- Hits          16714    16711       -3     
- Misses        13817    13819       +2     
- Partials       1635     1636       +1     

see 5 files with indirect coverage changes

@xingfudeshi xingfudeshi merged commit 4006df1 into apache:2.x Feb 15, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants