Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:compatible with tm module and rm-datasource module #6343

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

xingfudeshi
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6337
fixes #6336

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi changed the title Compatible with tm module and rm-datasource module optimize:compatible with tm module and rm-datasource module Feb 7, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@xingfudeshi
Copy link
Member Author

image

Fixed

@codecov-commenter
Copy link

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (74785d2) 51.95% compared to head (888778b) 51.21%.
Report is 6 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6343      +/-   ##
============================================
- Coverage     51.95%   51.21%   -0.75%     
+ Complexity     5171     5115      -56     
============================================
  Files           918      921       +3     
  Lines         32039    32166     +127     
  Branches       3866     3874       +8     
============================================
- Hits          16647    16473     -174     
- Misses        13768    14104     +336     
+ Partials       1624     1589      -35     
Files Coverage Δ
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...che/seata/common/exception/JsonParseException.java 100.00% <ø> (ø)
.../org/apache/seata/common/metadata/ClusterRole.java 100.00% <ø> (ø)
...ava/org/apache/seata/common/metadata/Metadata.java 100.00% <ø> (ø)
...apache/seata/common/metadata/MetadataResponse.java 80.00% <ø> (ø)
...in/java/org/apache/seata/common/metadata/Node.java 100.00% <ø> (ø)
...java/org/apache/seata/common/util/ConfigTools.java 100.00% <ø> (ø)
...ava/org/apache/seata/common/util/DurationUtil.java 83.33% <ø> (ø)
...a/org/apache/seata/common/util/HttpClientUtil.java 47.54% <ø> (ø)
...main/java/org/apache/seata/common/util/IOUtil.java 70.00% <ø> (ø)
... and 90 more

... and 165 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 486f582 into apache:2.x Feb 13, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatible with tm module Compatible with rm-datasource module
3 participants