Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove enableDegrade properties #6350

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove enableDegrade properties

Ⅱ. Does this pull request fix one issue?

fixes #6347

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5667d63) 52.38% compared to head (7f3f12d) 52.42%.
Report is 1 commits behind head on 2.x.

❗ Current head 7f3f12d differs from pull request most recent head 5c577b8. Consider uploading reports for the commit 5c577b8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6350      +/-   ##
============================================
+ Coverage     52.38%   52.42%   +0.03%     
- Complexity     5219     5221       +2     
============================================
  Files           920      920              
  Lines         31928    31924       -4     
  Branches       3807     3807              
============================================
+ Hits          16727    16735       +8     
+ Misses        13553    13544       -9     
+ Partials       1648     1645       -3     
Files Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...configure/properties/client/ServiceProperties.java 57.89% <ø> (+1.37%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit e5fab2d into apache:2.x Feb 19, 2024
4 of 5 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation lacks explanation of service.enableDegrade property
3 participants