Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix dynamic degradation does not work properly #6354

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix dynamic degradation does not work properly

Ⅱ. Does this pull request fix one issue?

fix #6353

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added this to the 2.1.0 milestone Feb 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (10bcd0f) 52.38% compared to head (8f7849e) 52.32%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6354      +/-   ##
============================================
- Coverage     52.38%   52.32%   -0.06%     
  Complexity     5216     5216              
============================================
  Files           920      920              
  Lines         31924    31942      +18     
  Branches       3807     3815       +8     
============================================
- Hits          16722    16714       -8     
- Misses        13554    13581      +27     
+ Partials       1648     1647       -1     
Files Coverage Δ
...handler/GlobalTransactionalInterceptorHandler.java 30.52% <0.00%> (-3.20%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/intergration-tx-api intergration-tx-api labels Feb 20, 2024
@funky-eyes funky-eyes merged commit 329384f into apache:2.x Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/intergration-tx-api intergration-tx-api type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

degradeNum is not working properly
3 participants