Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: tcc compatible #6387

Merged
merged 19 commits into from
Mar 8, 2024
Merged

Conversation

wt-better
Copy link
Contributor

  • I have registered the PR changes.
    io.seata tcc api compatible

@wt-better wt-better added this to the 2.1.0 milestone Mar 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 50.40%. Comparing base (d47a5d5) to head (3917071).

❗ Current head 3917071 differs from pull request most recent head 6551873. Consider uploading reports for the commit 6551873 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6387      +/-   ##
============================================
+ Coverage     50.38%   50.40%   +0.01%     
- Complexity     5250     5254       +4     
============================================
  Files           942      941       -1     
  Lines         33289    33279      -10     
  Branches       4037     4035       -2     
============================================
  Hits          16773    16773              
+ Misses        14891    14884       -7     
+ Partials       1625     1622       -3     
Files Coverage Δ
...pache/seata/spring/tcc/TccAnnotationProcessor.java 0.00% <ø> (ø)
...tcc/resource/parser/TccRegisterResourceParser.java 91.48% <100.00%> (ø)
...m/tcc/interceptor/TccActionInterceptorHandler.java 67.14% <78.78%> (-1.71%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect to add relevant test cases to prove that tcc has done full compatibility

@funky-eyes funky-eyes changed the title feature: tcc compatible optimize: tcc compatible Mar 4, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changes/zh-cn/2.x.md Outdated Show resolved Hide resolved
changes/en-us/2.x.md Outdated Show resolved Hide resolved
@funky-eyes funky-eyes merged commit 4027ff8 into apache:2.x Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants