Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize core compatible module #6412

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Mar 11, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize core compatible module

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.42%. Comparing base (4027ff8) to head (9988f88).
Report is 2 commits behind head on 2.x.

❗ Current head 9988f88 differs from pull request most recent head f971e6a. Consider uploading reports for the commit f971e6a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6412      +/-   ##
============================================
- Coverage     50.44%   50.42%   -0.02%     
+ Complexity     5259     5254       -5     
============================================
  Files           941      941              
  Lines         33279    33279              
  Branches       4035     4035              
============================================
- Hits          16786    16780       -6     
- Misses        14872    14875       +3     
- Partials       1621     1624       +3     

see 3 files with indirect coverage changes

@slievrly slievrly added the Do Not Merge Do not merge into develop label Mar 11, 2024
@slievrly slievrly removed the Do Not Merge Do not merge into develop label Mar 13, 2024
@slievrly slievrly added this to the 2.1.0 milestone Mar 13, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

Please register this PR in change log

@slievrly slievrly merged commit fa595e4 into apache:2.x Mar 26, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants