optimize: Compatible with the SPI 、saga、spring module #6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wt-better
changed the title
wt-better
requested review from
ptyin and
funky-eyes
and removed request for
ptyin
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6427 +/- ##
============================================
+ Coverage 50.26% 50.90% +0.64%
- Complexity 5242 5285 +43
============================================
Files 942 942
Lines 33270 33215 -55
Branches 4030 4022 -8
============================================
+ Hits 16722 16907 +185
+ Misses 14929 14649 -280
- Partials 1619 1659 +40
|
funky-eyes
added
module/common
slievrly
reviewed
Mar 16, 2024
common/src/main/java/org/apache/seata/common/loader/EnhancedServiceLoader.java
Show resolved
Hide resolved
slievrly
reviewed
Mar 16, 2024
compatible/src/main/java/io/seata/saga/engine/config/DbStateMachineConfig.java
Show resolved
Hide resolved
slievrly
reviewed
Mar 27, 2024
compatible/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
Show resolved
Hide resolved
slievrly
reviewed
Mar 27, 2024
compatible/src/main/java/io/seata/saga/statelang/domain/impl/StateMachineInstanceImpl.java
Show resolved
Hide resolved
ptyin
reviewed
Mar 27, 2024
compatible/src/main/java/io/seata/saga/rm/SagaResourceManager.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Apr 7, 2024
saga/seata-saga-rm/src/main/java/org/apache/seata/saga/rm/StateMachineEngineHolder.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Apr 7, 2024
compatible/src/test/java/io/seata/saga/engine/mock/DemoService.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fixes #6428
Compatible with the SPI module, loads all extensions of io.seata and apache seata, and ensures that io.seata takes precedence under the same name. It should be noted that if the io.seata compatible interface is not inherited from apache.seata, only apache will be loaded. extension of seata
Compatible with saga module and add related single tests
Compatible with the enableDatasourceProxy annotation and GlobalTransactionScaner of the spring module
1、兼容SPI模块，加载io.seata和apache seata的所有扩展，并且保证相同名称下io.seata优先，需要注意的是如果io.seata兼容的接口不是继承自apache.seata，仅会加载apache.seata的扩展
2、兼容saga模块，增加相关单测
3、兼容spring模块的enableDatasourceProxy注解和GlobalTransactionScaner