Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhance test coverage of seata common #6430

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

MikhailNavitski
Copy link
Contributor

@MikhailNavitski MikhailNavitski commented Mar 16, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Enhance the test coverage of seata-common module.

Ⅱ. Does this pull request fix one issue?

It's a partial fix of #187 .

Ⅲ. Why don't you add test cases (unit test/integration test)?


Ⅳ. Describe how to verify it

Run tests and coverage of seata-common module.

Ⅴ. Special notes for reviews

@MikhailNavitski MikhailNavitski force-pushed the MikhailNavitski_test_common branch 2 times, most recently from ac1d53e to 6989013 Compare March 16, 2024 21:20
@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label Mar 18, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 9e78cdd into apache:2.x Mar 20, 2024
4 of 6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants