Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add null value check for MAC address #6458

Merged
merged 1 commit into from
Apr 23, 2024
Merged

optimize: add null value check for MAC address #6458

merged 1 commit into from
Apr 23, 2024

Conversation

bageyang
Copy link
Contributor

@bageyang bageyang commented Apr 2, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add null value check for MAC address

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 50.85%. Comparing base (d318409) to head (3d1d104).
Report is 8 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6458      +/-   ##
============================================
+ Coverage     50.81%   50.85%   +0.03%     
  Complexity     5285     5285              
============================================
  Files           942      942              
  Lines         33270    33270              
  Branches       4030     4030              
============================================
+ Hits          16907    16919      +12     
+ Misses        14698    14685      -13     
- Partials       1665     1666       +1     
Files Coverage Δ
...in/java/org/apache/seata/common/util/IdWorker.java 83.33% <50.00%> (ø)

... and 2 files with indirect coverage changes

@funky-eyes funky-eyes added the Do Not Merge Do not merge into develop label Apr 3, 2024
@funky-eyes funky-eyes removed the Do Not Merge Do not merge into develop label Apr 22, 2024
@funky-eyes funky-eyes added this to the 2.1.0 milestone Apr 22, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请登记pr和作者信息至https://github.com/apache/incubator-seata/tree/2.x/changes 中的中英两版2.x.md文件
Please register PR and author information to the Chinese and English 2.x.md in the https://github.com/apache/incubator-seata/tree/2.x/changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit aa74ef0 into apache:2.x Apr 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants