Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix FileConfigurationTest and MockServerTest fail #6484

Merged
merged 49 commits into from
Apr 22, 2024

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added the Do Not Merge Do not merge into develop label Apr 18, 2024
@funky-eyes funky-eyes removed the Do Not Merge Do not merge into develop label Apr 22, 2024
@funky-eyes funky-eyes changed the title [WIP]test: optimize FileConfigurationTest test: fix FileConfigurationTest and MockServerTest fail Apr 22, 2024
Copy link
Contributor

@liuqiufeng liuqiufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -37,16 +41,22 @@ public class MockServerTest {

static String RESOURCE_ID = "mock-action";

Logger logger = LoggerFactory.getLogger(MockServerTest.class);

@BeforeAll
Copy link
Contributor

@Bughue Bughue Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前一直在考虑有没有必要在这里用@ BeforeEach ,不然在单个@test方法里这个不会重新执行,这次可以再考虑下要不要改
I've been wondering if it's necessary to use @ BeforeEach here, otherwise this won't be re-executed in a single @test method, so I'll reconsider this time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑后续再做修改,暂时先尽最大能力节约ci的耗时
Consider subsequent modifications, and do your best to save the time-consuming ci for the time being.

@Bughue
Copy link
Contributor

Bughue commented Apr 22, 2024

LGTM

@funky-eyes funky-eyes merged commit 1ee8313 into apache:2.x Apr 22, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants