bugfix: fix XA rollback on commit failure (#6492) #6496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Apr 23, 2024
rm-datasource/src/main/java/org/apache/seata/rm/datasource/xa/ConnectionProxyXA.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Apr 23, 2024
tanyaofei
force-pushed
the
2.x
branch
2 times, most recently
from
c56cfad
to
9eced11
Compare
funky-eyes
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
LGTM
Please send your DingTalk account to my email address [email protected], and I will invite you to join the Seata developer group.
funky-eyes
added
type: bug
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
修复 XA 模式下执行长时间 SQL(或死锁 SQL) 没有完成回滚就
closeⅡ. Does this pull request fix one issue?
fixes #6492
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
autoCommit = true的情况下SQLSTATE_XA_NOT_END可以避免ExecuteTemplateXA再次rollbackautoCommit = false的情况下不会 doRollbackOnCommitException