Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: revise the notice file #6610

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

revise the notice file

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added this to the 2.1.0 milestone Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.37%. Comparing base (933b492) to head (ce6443a).
Report is 9 commits behind head on 2.x.

Current head ce6443a differs from pull request most recent head 9fe7090

Please upload reports for the commit 9fe7090 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6610      +/-   ##
============================================
- Coverage     51.13%   50.37%   -0.76%     
- Complexity     5317     5465     +148     
============================================
  Files           950     1005      +55     
  Lines         33448    34754    +1306     
  Branches       4048     4139      +91     
============================================
+ Hits          17103    17509     +406     
- Misses        14666    15539     +873     
- Partials       1679     1706      +27     

see 53 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 0e4061f into apache:2.x Jun 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Finished
Development

Successfully merging this pull request may close these issues.

3 participants