Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve the test case coverage of saga module to 70% #6647

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Jul 6, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix(#6509): improve the test case coverage of saga module to 70%

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.24%. Comparing base (933b492) to head (2590f37).
Report is 27 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6647      +/-   ##
============================================
- Coverage     51.13%   50.24%   -0.89%     
- Complexity     5317     5596     +279     
============================================
  Files           950     1023      +73     
  Lines         33448    35440    +1992     
  Branches       4048     4218     +170     
============================================
+ Hits          17103    17808     +705     
- Misses        14666    15868    +1202     
- Partials       1679     1764      +85     

see 122 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 6, 2024
@funky-eyes funky-eyes added module/saga saga module type: test test case labels Jul 6, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title fix(6509): improve the test case coverage of saga module to 70% test: improve the test case coverage of saga module to 70% Jul 6, 2024
@funky-eyes funky-eyes merged commit 238cf3a into apache:2.x Jul 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/saga saga module type: test test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants