bugfix: add three tcc fence interceptors to fix tcc fence deadlock ex… #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Jul 29, 2024
funky-eyes
reviewed
Jul 29, 2024
| /** | ||
| * The constant KEY_RESOURCE_ID. | ||
| */ | ||
| public static final String KEY_RESOURCE_ID = "TX_RESOURCE_ID"; |
There was a problem hiding this comment.
Rootcontext不应该用来存放这些数据
Rootcontext should not be used to store this data
| @@ -42,6 +34,14 @@ | |||
| import org.slf4j.LoggerFactory; | |||
| import org.slf4j.MDC; | |||
|
|
|||
| import javax.annotation.Nonnull; | |||
There was a problem hiding this comment.
java的包应该在顶层
Java packages should be at the top level
| import org.springframework.transaction.support.TransactionTemplate; | ||
|
|
||
| import javax.sql.DataSource; |
| * @param targetInterceptorClass the target interceptor class | ||
| * @return boolean | ||
| */ | ||
| public static boolean hasTransactionAspectBeforeInterceptor(Method method, Object proxy, Class<?> targetInterceptorClass) { |
There was a problem hiding this comment.
为什么不在代理bean的时候就初始化好一切信息？
Why not initialize everything in the proxy bean?
added 2 commits
July 29, 2024 11:03
…ever/incubator-seata into clever_fix_tcc_deadlock_v2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6706 +/- ##
============================================
- Coverage 50.02% 49.66% -0.37%
Complexity 5734 5734
============================================
Files 1051 1055 +4
Lines 36340 36643 +303
Branches 4321 4369 +48
============================================
+ Hits 18179 18198 +19
- Misses 16365 16645 +280
- Partials 1796 1800 +4
|
funky-eyes
reviewed
Jul 29, 2024
| * @param bean bean | ||
| * @throws Exception | ||
| */ | ||
| private static void addTccFenceAdvisorsForBean(Object bean) throws Exception { |
There was a problem hiding this comment.
为什么要增加这个方法？
Why add this method?
| @@ -121,6 +122,10 @@ public BranchStatus branchCommit(BranchType branchType, String xid, long branchI | |||
| Object[] args = this.getTwoPhaseCommitArgs(tccResource, businessActionContext); | |||
| Object ret; | |||
| boolean result; | |||
| RootContext.bind(xid); | |||
There was a problem hiding this comment.
二阶段为什么要使用rootcontext？
Why use rootcontext in Phase 2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ception (#6679)
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6679
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews