-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the error of active refresh failure of cross-database table metadata #6759
Conversation
… incorrect caching of tables with the same name across databases
# Conflicts: # common/src/main/java/org/apache/seata/common/ConfigurationKeys.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6759 +/- ##
=========================================
Coverage 52.31% 52.31%
- Complexity 6375 6377 +2
=========================================
Files 1078 1078
Lines 37483 37485 +2
Branches 4440 4438 -2
=========================================
+ Hits 19608 19612 +4
Misses 15938 15938
+ Partials 1937 1935 -2
|
.../src/main/java/org/apache/seata/rm/datasource/sql/struct/cache/PostgresqlTableMetaCache.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/seata/rm/datasource/sql/struct/cache/SqlServerTableMetaCache.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
...ource/src/main/java/org/apache/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java
Outdated
Show resolved
Hide resolved
...urce/src/main/java/org/apache/seata/rm/datasource/sql/struct/cache/OracleTableMetaCache.java
Outdated
Show resolved
Hide resolved
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Fixed the error that may cause failure to refresh table metadata cache across databases under the same resourceId due to lack of original table name information
Ⅱ. Does this pull request fix one issue?
fixes #6685
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews