Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the error of active refresh failure of cross-database table metadata #6759

Merged
merged 12 commits into from
Sep 3, 2024

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Aug 15, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Fixed the error that may cause failure to refresh table metadata cache across databases under the same resourceId due to lack of original table name information

Ⅱ. Does this pull request fix one issue?

fixes #6685

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.31%. Comparing base (9263976) to head (fb09700).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...urce/sql/struct/cache/SqlServerTableMetaCache.java 50.00% 3 Missing ⚠️
...a/org/apache/seata/sqlparser/struct/TableMeta.java 0.00% 3 Missing ⚠️
...ource/sql/struct/cache/AbstractTableMetaCache.java 75.00% 0 Missing and 1 partial ⚠️
...ource/sql/struct/cache/PolarDBXTableMetaCache.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6759   +/-   ##
=========================================
  Coverage     52.31%   52.31%           
- Complexity     6375     6377    +2     
=========================================
  Files          1078     1078           
  Lines         37483    37485    +2     
  Branches       4440     4438    -2     
=========================================
+ Hits          19608    19612    +4     
  Misses        15938    15938           
+ Partials       1937     1935    -2     
Files with missing lines Coverage Δ
.../datasource/sql/struct/cache/DmTableMetaCache.java 83.33% <100.00%> (+0.18%) ⬆️
...source/sql/struct/cache/MariadbTableMetaCache.java 77.77% <100.00%> (ø)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 86.81% <100.00%> (+2.03%) ⬆️
...asource/sql/struct/cache/OracleTableMetaCache.java 66.99% <100.00%> (-0.32%) ⬇️
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 78.57% <100.00%> (+3.82%) ⬆️
...ource/sql/struct/cache/AbstractTableMetaCache.java 83.33% <75.00%> (-1.97%) ⬇️
...ource/sql/struct/cache/PolarDBXTableMetaCache.java 11.11% <0.00%> (ø)
...urce/sql/struct/cache/SqlServerTableMetaCache.java 78.70% <50.00%> (-0.20%) ⬇️
...a/org/apache/seata/sqlparser/struct/TableMeta.java 69.86% <0.00%> (-3.00%) ⬇️

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module type: optimize multilingual labels Aug 16, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 16, 2024
@xingfudeshi xingfudeshi changed the title Bugfix: fix the error of active refresh failure of cross-database table metadata bugfix: fix the error of active refresh failure of cross-database table metadata Aug 18, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit cd2e6d2 into apache:2.x Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module multilingual type: bug Category issues or prs related to bug. type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get table meta error
4 participants