Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: automatic deletion of namingserver vgroup through Caffeine map #6770

Merged
merged 28 commits into from
Aug 23, 2024

Conversation

ggbocoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@ggbocoder ggbocoder changed the title Optimize:optimize namingserver Optimize:optimize namingserver caffeine map Aug 23, 2024
@ggbocoder ggbocoder changed the title Optimize:optimize namingserver caffeine map Optimize:Automatic deletion of namingserver vgroup through Caffeine map Aug 23, 2024
…mingserver

# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 23, 2024
@funky-eyes funky-eyes changed the title Optimize:Automatic deletion of namingserver vgroup through Caffeine map optimize:Automatic deletion of namingserver vgroup through Caffeine map Aug 23, 2024
@funky-eyes funky-eyes changed the title optimize:Automatic deletion of namingserver vgroup through Caffeine map optimize: automatic deletion of namingserver vgroup through Caffeine map Aug 23, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 60.78431% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.27%. Comparing base (5601c36) to head (65152ed).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...ache/seata/namingserver/manager/NamingManager.java 60.71% 6 Missing and 5 partials ⚠️
.../src/main/java/org/apache/seata/server/Server.java 76.92% 3 Missing ⚠️
...common/metadata/namingserver/NamingServerNode.java 33.33% 2 Missing ⚠️
...ache/seata/namingserver/entity/bo/NamespaceBO.java 60.00% 1 Missing and 1 partial ⚠️
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% 1 Missing ⚠️
...ver/storage/db/store/VGroupMappingDataBaseDAO.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6770      +/-   ##
============================================
+ Coverage     52.15%   52.27%   +0.11%     
- Complexity     6289     6302      +13     
============================================
  Files          1064     1064              
  Lines         37194    37215      +21     
  Branches       4414     4417       +3     
============================================
+ Hits          19399    19454      +55     
+ Misses        15882    15837      -45     
- Partials       1913     1924      +11     
Files Coverage Δ
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% <0.00%> (ø)
...ver/storage/db/store/VGroupMappingDataBaseDAO.java 0.00% <0.00%> (ø)
...common/metadata/namingserver/NamingServerNode.java 36.66% <33.33%> (-0.38%) ⬇️
...ache/seata/namingserver/entity/bo/NamespaceBO.java 73.68% <60.00%> (-4.89%) ⬇️
.../src/main/java/org/apache/seata/server/Server.java 49.18% <76.92%> (+2.88%) ⬆️
...ache/seata/namingserver/manager/NamingManager.java 65.88% <60.71%> (-1.12%) ⬇️

... and 7 files with indirect coverage changes

@funky-eyes funky-eyes merged commit a4f0463 into apache:2.x Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants