Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: compilation and packaging for the ARM64 architecture #6803

Merged
merged 11 commits into from
Sep 13, 2024

Conversation

heliang666s
Copy link
Contributor

@heliang666s heliang666s commented Sep 1, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Because Protobuf does not have an ARM version, according to the experience of other communities, the x86 version can only be forcibly used to compile and build properly. And Google doesn't seem to have the intention of fixing, and the protobuf community has issues and PRs about Apple Sicilion chips not compiling, but the community has not responded in any way.

grpc/grpc-java#7690

Ⅱ. Does this pull request fix one issue?

fixes #6798

Ⅲ. Why don't you add test cases (unit test/integration test)?

unnecessary

Ⅳ. Describe how to verify it

unnecessary

Ⅴ. Special notes for reviews

unnecessary

integration/grpc/pom.xml Outdated Show resolved Hide resolved
@funky-eyes
Copy link
Contributor

Hi @heliang666s
Can you answer the question posed by @slievrly ?

integration/grpc/pom.xml Outdated Show resolved Hide resolved
integration/grpc/pom.xml Outdated Show resolved Hide resolved
integration/grpc/pom.xml Outdated Show resolved Hide resolved
serializer/seata-serializer-protobuf/pom.xml Outdated Show resolved Hide resolved
serializer/seata-serializer-protobuf/pom.xml Outdated Show resolved Hide resolved
@funky-eyes funky-eyes added first-time contributor first-time contributor module/integration integration module module/serializer serializer module labels Sep 12, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 12, 2024
@funky-eyes funky-eyes changed the title upgrade com.google.protobuf:protoc:exe dependency optimize: upgrade com.google.protobuf:protoc:exe dependency Sep 12, 2024
@funky-eyes funky-eyes changed the title optimize: upgrade com.google.protobuf:protoc:exe dependency optimize: compilation and packaging for the ARM64 architecture Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 46.07219% with 254 lines in your changes missing coverage. Please review.

Project coverage is 52.29%. Comparing base (9263976) to head (236a69f).
Report is 26 commits behind head on 2.x.

Files with missing lines Patch % Lines
...apache/seata/config/zk/ZookeeperConfiguration.java 52.67% 47 Missing and 6 partials ⚠️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 59.80% 35 Missing and 6 partials ⚠️
...ce/undo/sqlserver/SqlServerUndoDeleteExecutor.java 5.40% 34 Missing and 1 partial ⚠️
...g/apache/seata/server/instance/ServerInstance.java 9.37% 28 Missing and 1 partial ⚠️
...n/tx/api/interceptor/ActionInterceptorHandler.java 0.00% 16 Missing ⚠️
...ache/seata/namingserver/manager/NamingManager.java 38.46% 11 Missing and 5 partials ⚠️
...va/org/apache/seata/rm/tcc/TCCResourceManager.java 66.66% 12 Missing and 4 partials ⚠️
...a/server/storage/db/lock/LockStoreDataBaseDAO.java 33.33% 5 Missing and 3 partials ⚠️
...a/org/apache/seata/common/util/HttpClientUtil.java 20.00% 4 Missing ⚠️
.../integration/tx/api/fence/hook/TccHookManager.java 78.94% 1 Missing and 3 partials ⚠️
... and 16 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6803      +/-   ##
============================================
- Coverage     52.31%   52.29%   -0.02%     
- Complexity     6375     6410      +35     
============================================
  Files          1078     1083       +5     
  Lines         37483    37913     +430     
  Branches       4440     4492      +52     
============================================
+ Hits          19608    19828     +220     
- Misses        15938    16115     +177     
- Partials       1937     1970      +33     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...e/seata/common/metadata/namingserver/Instance.java 41.79% <ø> (-0.86%) ⬇️
...common/metadata/namingserver/NamingServerNode.java 34.61% <ø> (-2.06%) ⬇️
...g/apache/seata/config/processor/ProcessorYaml.java 100.00% <100.00%> (ø)
...try/namingserver/NamingserverRegistryProvider.java 0.00% <ø> (ø)
...he/seata/namingserver/entity/pojo/ClusterData.java 70.90% <ø> (+3.11%) ⬆️
.../datasource/sql/struct/cache/DmTableMetaCache.java 83.33% <100.00%> (+0.18%) ⬆️
...source/sql/struct/cache/MariadbTableMetaCache.java 77.77% <100.00%> (ø)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 86.81% <100.00%> (+2.03%) ⬆️
... and 31 more

... and 18 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
请在上述md文件中登记pr信息和作者信息
Please register pr information and author information in the above md file

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit c0bb126 into apache:2.x Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/integration integration module module/serializer serializer module type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade com.google.protobuf:protoc:exe dependency
4 participants