Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve the test case #6821

Merged
merged 2 commits into from
Sep 6, 2024
Merged

test: Improve the test case #6821

merged 2 commits into from
Sep 6, 2024

Conversation

wuwen5
Copy link
Contributor

@wuwen5 wuwen5 commented Sep 6, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6813

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 6, 2024
@funky-eyes funky-eyes added type: test test case module/metrics metrics module labels Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (242d92c) to head (cd98ca9).
Report is 3 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6821      +/-   ##
============================================
+ Coverage     52.30%   52.43%   +0.13%     
+ Complexity     6387     6381       -6     
============================================
  Files          1080     1080              
  Lines         37552    37554       +2     
  Branches       4447     4449       +2     
============================================
+ Hits          19641    19692      +51     
+ Misses        15977    15914      -63     
- Partials       1934     1948      +14     

see 17 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 27973af into apache:2.x Sep 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/metrics metrics module type: test test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompactSummaryTest.testTps:73 expected: <true> but was: <false>
2 participants