Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: raft mode is backward compatible with version 2.0 #6850

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 13, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Sep 13, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.31%. Comparing base (c0bb126) to head (6a937ea).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6850      +/-   ##
============================================
+ Coverage     52.29%   52.31%   +0.02%     
- Complexity     6411     6416       +5     
============================================
  Files          1083     1083              
  Lines         37913    37918       +5     
  Branches       4492     4494       +2     
============================================
+ Hits          19827    19838      +11     
+ Misses        16116    16110       -6     
  Partials       1970     1970              
Files with missing lines Coverage Δ
...er/cluster/raft/serializer/CustomDeserializer.java 55.55% <ø> (+55.55%) ⬆️
...ver/cluster/raft/serializer/JacksonSerializer.java 84.61% <100.00%> (+3.66%) ⬆️

... and 2 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 785b20c into apache:2.x Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants