Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DISCLAIMER to jars #1299

Closed
pjfanning opened this issue Sep 15, 2024 · 2 comments
Closed

add DISCLAIMER to jars #1299

pjfanning opened this issue Sep 15, 2024 · 2 comments
Assignees
@rzo1
Milestone
3.2.0

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Sep 15, 2024 •
edited
Loading

The LICENSE and NOTICE are in the RC jars but not the DISCLAIMER. I'm not sure if it 100% required but many podlings include it.

I checked stormcrawler-core-3.1.0.jar
@rzo1
Copy link
Contributor

rzo1 commented Sep 15, 2024

It is required for release artifacts, which is the source artifact by ASF definition: https://apache.org/legal/release-policy.html#source-packages

Maven artifacts are convenience. I am not aware of an strict incubator policy for this class of files.

@pjfanning
Copy link
Contributor Author

The apache-parent pom.xml appears to have a feature to allow adding a disclaimer to jars. See apache/incubator-xtable#539 (mainly for the code change).

@rzo1 rzo1 added this to the 3.1.1 milestone Sep 24, 2024
@rzo1 rzo1 self-assigned this Sep 26, 2024
rzo1 added a commit that referenced this issue Sep 26, 2024
@rzo1
#1299 - Add DISCLAIMER to JAR files
5628b4e
rzo1 added a commit that referenced this issue Sep 26, 2024
@rzo1
#1299 - Add DISCLAIMER to JAR files
d605c64
@rzo1 rzo1 closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzo1 rzo1

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
2 participants
@pjfanning @rzo1