[Relay, TF Frontend] Dilation2D operator support #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siju-samuel
reviewed
Mar 12, 2020
python/tvm/relay/op/nn/nn.py
Outdated
Comment on lines
2419
to
2420
| out_layout : Optional[str] | ||
| Layout of the output, by default, out_layout is the same as data_layout |
There was a problem hiding this comment.
out_layout is not part of parameter
topi/python/topi/nn/dilation2d.py
Outdated
Comment on lines
39
to
50
| dilation: int or a list/tuple of two ints | ||
| dilation size, or [dilation_height, dilation_width] | ||
| Returns |
topi/python/topi/nn/dilation2d.py
Outdated
Comment on lines
101
to
122
| dilation: int or a list/tuple of two ints | ||
| dilation size, or [dilation_height, dilation_width] | ||
| Returns | ||
| ------- |
kevinthesun
reviewed
Mar 12, 2020
| @@ -442,6 +442,57 @@ def conv1d_transpose_strategy(attrs, inputs, out_type, target): | |||
| name="conv1d_transpose_ncw.generic") | |||
| return strategy | |||
|
|
|||
|
|
|||
| # dilation2d | |||
| def wrap_compute_dilation2d(topi_compute, need_data_layout=False, need_out_layout=False): | |||
There was a problem hiding this comment.
need_out_layout is not used?
kevinthesun
reviewed
Mar 12, 2020
topi/python/topi/nn/dilation2d.py
Outdated
| from .util import get_pad_tuple | ||
|
|
||
|
|
||
| def dilation2d_nchw(input, filter, stride, padding, dilation, out_dtype=None): |
There was a problem hiding this comment.
In relay op we use rate as the name for dilation rate, but here we use dilation. Do we want to keep them consistent?
There was a problem hiding this comment.
Now using 'dilations' instead of 'rates' everywhere. This will be consistent with TF2's Dilation2d op and also with other TVM Conv operators as well.
|
It looks like commit history of this PR has diverged? |
maheshambule
force-pushed
the
dilation2d_op
branch
from
a357422
to
30b6d07
Compare
|
@kevinthesun, Yes working on it. |
maheshambule
force-pushed
the
dilation2d_op
branch
from
636694e
to
b8eb6b9
Compare
|
@kevinthesun, @siju-samuel Thanks for the review. Review comments are incorporated. Let me know if there are further comments. |
|
Thanks @maheshambule @siju-samuel |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* update docs for dilation 2d * dilation2d compute * dilation2d register * dilation2d rel compute * dilation2d strategy * dilation2d attrs * dilation2d generic schedule * dilation2d tf frontend support * dilation2d tf frontend test case * dilation2d test cases * pylint fixes * add exception for cuda target * Update docstring * Update docstring * change rates to dilations * removed unused param * merge master * Update nn.py * Update nn.py
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* update docs for dilation 2d * dilation2d compute * dilation2d register * dilation2d rel compute * dilation2d strategy * dilation2d attrs * dilation2d generic schedule * dilation2d tf frontend support * dilation2d tf frontend test case * dilation2d test cases * pylint fixes * add exception for cuda target * Update docstring * Update docstring * change rates to dilations * removed unused param * merge master * Update nn.py * Update nn.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Dilation2D operator.
It is supported in Tensorflow.
https://www.tensorflow.org/api_docs/python/tf/nn/dilation2d
Currently, generic implementation is added. The device-specific which is there for other convolution operators is not added.
cc: @yongwww, @zhiics, @kevinthesun, @masahi, @comaniac