[TOPI, Relay refactor] Move Dilation2d from nn to image namespace #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masahi, Thanks for the refactoring. The dilate.py and dilation2d.py in the same folder was confusing. I should have kept it in image namespace. |
jwfromm
approved these changes
Mar 20, 2020
|
@kevinthesun ready to merge, I just moved things around. |
tqchen
approved these changes
Mar 20, 2020
|
THanks @masahi @maheshambule @jwfromm ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dilation2d added in #5033 is a morphological operation, not a standard neural network operator. So putting this inside of image name space seems be to a better choice to me.
I noticed this when looking at topi/nn directory. There are now dilate.py and dilation2d.py, too similar functions but the former is used for conv transpose (dilate with 0) while the latter is for morphological dilation (dilate with max in the window). I thought it was confusing, so moved dilation2d.py to topi/image. Applied the same fix to Relay as well.
please review @kevinthesun @jwfromm @maheshambule I'm sorry I missed this in the original PR.