Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11493][SDK] Inlong SDK Dirty Sink supports retry sending #11498

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

vernedeng
Copy link
Contributor

Fixes #11493

Motivation

Add the ability to retry and limit the amount of dirty SDK in flight

Modifications

Add two options to configure max retry time and the max callback size

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

aloyszhang
aloyszhang previously approved these changes Nov 13, 2024
fuweng11
fuweng11 previously approved these changes Nov 13, 2024
@vernedeng vernedeng dismissed stale reviews from fuweng11 and aloyszhang via 55cf538 November 14, 2024 02:35
@dockerzhang dockerzhang merged commit f493862 into apache:master Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][SDK] Inlong SDK Dirty Sink supports retry sending
5 participants