Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8436][Sort] Fix the backfill task not running bug in oracle cdc connector #8437

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

e-mhui
Copy link
Contributor

@e-mhui e-mhui commented Jul 5, 2023

Prepare a Pull Request

[INLONG-8436][Sort] Fix the backfill task not running bug in oracle cdc connector

Motivation

Fix the backfill task not running bug in oracle cdc connector.

Modifications

  1. In the OracleScanFetchTask#doExecute method, for Snapshot step 3, we need to set the highWatermark instead of the lowWatermark.
((SnapshotSplitChangeEventSourceContext) (context)).setHighWatermark(highWatermark);
  1. The RedoLogSplitReadTask should use the StartingOffset of RedoLogSplit instead of the StartingOffset of SnapshotSplit.
            final RedoLogSplitReadTask backfillRedoLogReadReTask =
                    createBackfillRedoLogReadTask(backfillRedoLogSplit, sourceFetchContext);
            final LogMinerOracleOffsetContextLoader loader =
                    new LogMinerOracleOffsetContextLoader(
                            ((OracleSourceFetchTaskContext) context).getDbzConnectorConfig());
            final OracleOffsetContext oracleOffsetContext =
                    loader.load(backfillRedoLogSplit.getStartingOffset().getOffset());
            backfillRedoLogReadReTask.execute(
                    new SnapshotStreamSplitChangeEventSourceContext(), oracleOffsetContext);

@e-mhui e-mhui marked this pull request as ready for review August 15, 2023 13:12
@EMsnap EMsnap merged commit fa13965 into apache:master Aug 16, 2023
11 checks passed
liaosunny123 pushed a commit to liaosunny123/inlong that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The backfill task not running bug in oracle cdc connector
3 participants