Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8653][Sort] Fix the query sql for jdbc sink postgres dialect multiple table scenerios. #8654

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

Yizhou-Yang
Copy link
Contributor

Prepare a Pull Request

Motivation

plz refer to issue

Modifications

adjusted the sql.

Verifying this change

This change is used in the production environment.

@dockerzhang dockerzhang changed the title [INLONG-8653][Sort] fix the query sql for postgres cdc multiple table scenerios. [INLONG-8653][Sort] Fix the query sql for postgres cdc multiple table scenerios. Aug 7, 2023
@Yizhou-Yang Yizhou-Yang marked this pull request as ready for review August 28, 2023 06:01
@gong
Copy link
Contributor

gong commented Aug 28, 2023

The title is error. This is not pg cdc, it is improve for sink to pg. @Yizhou-Yang
Modify issue desciption and PR title

Copy link
Contributor

@gong gong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it compatible with regular pg databases?

@Yizhou-Yang Yizhou-Yang changed the title [INLONG-8653][Sort] Fix the query sql for postgres cdc multiple table scenerios. [INLONG-8653][Sort] Fix the query sql for jdbc sink multiple table scenerios. Aug 30, 2023
@Yizhou-Yang
Copy link
Contributor Author

Is it compatible with regular pg databases?

Fixed title. It is compatible with regular pg, as indicated by the comment above.

@Yizhou-Yang Yizhou-Yang changed the title [INLONG-8653][Sort] Fix the query sql for jdbc sink multiple table scenerios. [INLONG-8653][Sort] Fix the query sql for jdbc sink postgres dialect multiple table scenerios. Aug 30, 2023
@gong
Copy link
Contributor

gong commented Aug 31, 2023

@Yizhou-Yang The issue description need modfiy, not cdc pg.

@dockerzhang dockerzhang merged commit 3a4216e into apache:master Sep 11, 2023
11 checks passed
liaosunny123 pushed a commit to liaosunny123/inlong that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Sort] fix the query sql for jdbc pg dialect multiple table scenerios.
5 participants