Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-8358][Sort] Add kafka connector on flink 1.15 #8713

Merged
merged 19 commits into from
Dec 12, 2023
Merged

[INLONG-8358][Sort] Add kafka connector on flink 1.15 #8713

merged 19 commits into from
Dec 12, 2023

Conversation

hnrainll
Copy link
Contributor

Prepare a Pull Request

Motivation

Add kafka connector on flink 1.15

Modifications

Add kafka connector on flink 1.15

@hnrainll hnrainll marked this pull request as draft August 14, 2023 03:12
@EMsnap EMsnap marked this pull request as ready for review August 21, 2023 03:24
@EMsnap EMsnap marked this pull request as draft August 21, 2023 03:24
@hnrainll hnrainll marked this pull request as ready for review September 17, 2023 14:45
EMsnap
EMsnap reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a end to end test under sort-end-to-end-tests to test the code thx ~

@hnrainll
Copy link
Contributor Author

Please add a end to end test under sort-end-to-end-tests to test the code thx ~

ok

@dockerzhang
Copy link
Contributor

@hnrainll please fix the conflicts, thanks.

@hnrainll
Copy link
Contributor Author

hnrainll commented Oct 6, 2023

@hnrainll please fix the conflicts, thanks.

OK

@hnrainll hnrainll force-pushed the INLONG-8358 branch 2 times, most recently from 095ca3c to a2d54ed Compare October 7, 2023 12:47
@EMsnap
Copy link
Contributor

EMsnap commented Nov 27, 2023 •
edited by dockerzhang
Loading

Sorry but there should be UT for this feature, any problem with implementing it ?

@hnrainll
Copy link
Contributor Author

Sorry but there should be UT for this feature, any problem with implementing it ?

No problem, I'm in the process of implementing UT's functionality.

@hnrainll hnrainll force-pushed the INLONG-8358 branch 2 times, most recently from 6b2f47b to a106ef8 Compare December 5, 2023 03:59
@hnrainll hnrainll requested a review from EMsnap December 6, 2023 07:03
healchow
healchow previously approved these changes Dec 6, 2023
View reviewed changes
@hnrainll hnrainll requested a review from EMsnap December 6, 2023 08:18
EMsnap
EMsnap approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMsnap EMsnap merged commit cf28445 into apache:master Dec 12, 2023
9 checks passed
@hnrainll hnrainll deleted the INLONG-8358 branch December 12, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-mhui e-mhui e-mhui approved these changes

@vernedeng vernedeng vernedeng approved these changes

@healchow healchow healchow approved these changes

@EMsnap EMsnap EMsnap approved these changes

Assignees
No one assigned
Labels
component/sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Add Kafka connector on Flink 1.15
6 participants
@hnrainll @dockerzhang @EMsnap @healchow @vernedeng @e-mhui