Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AINode status error after ConfigNode Leader restarts #13547

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix AINode status error after ConfigNode Leader restarts #13547

merged 1 commit into from
Sep 20, 2024

Conversation

OneSizeFitsQuorum
Copy link
Contributor

image

@OneSizeFitsQuorum
finish
09cd4b2 
Signed-off-by: OneSizeFitQuorum <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.78%. Comparing base (5387a10) to head (09cd4b2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...iotdb/confignode/manager/load/cache/LoadCache.java 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #13547      +/-   ##
============================================
- Coverage     41.78%   41.78%   -0.01%     
  Complexity       71       71              
============================================
  Files          3977     3977              
  Lines        247417   247422       +5     
  Branches      29959    29959              
============================================
- Hits         103379   103377       -2     
- Misses       144038   144045       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisdutz chrisdutz self-requested a review September 20, 2024 06:45
chrisdutz
chrisdutz approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@chrisdutz chrisdutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Tested it on a Google Compute Cloud installation and it resolved the issues)

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 1940261 into master Sep 20, 2024
29 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the fix_confignode_restart_ainode_error branch September 20, 2024 07:11
OneSizeFitsQuorum added a commit that referenced this pull request Sep 20, 2024
@OneSizeFitsQuorum
Fix AINode status error after ConfigNode Leader restarts #13547
b8deec2 
Signed-off-by: OneSizeFitQuorum <[email protected]>
OneSizeFitsQuorum added a commit that referenced this pull request Sep 20, 2024
@OneSizeFitsQuorum
Fix AINode status error after ConfigNode Leader restarts #13547 (#13556)
a77a625 
Signed-off-by: OneSizeFitQuorum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdutz chrisdutz chrisdutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OneSizeFitsQuorum @chrisdutz