Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/show ainodes command #13592

Merged
merged 65 commits into from
Sep 25, 2024

Conversation

chrisdutz
Copy link
Contributor

Implemented the "show ainodes" command for the table model.

chrisdutz and others added 30 commits August 17, 2023 11:31
@chrisdutz chrisdutz changed the title Feature/show ainode command Feature/show ainodes command Sep 23, 2024
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Caideyipi Caideyipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good codes! But there seems to be a few points to improve ;-)

@@ -781,6 +786,7 @@ COMMITTED: 'COMMITTED';
CONDITION: 'CONDITION';
CONDITIONAL: 'CONDITIONAL';
CONFIGNODES: 'CONFIGNODES';
AINODES: 'AINODES';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using lexicographical order here is better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure ... quick fix ... I just always put it under the config node ... but didn't realize that list was alphabetically sorted.

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 0137093 into apache:master Sep 25, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants