-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/show ainodes command #13592
Feature/show ainodes command #13592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good codes! But there seems to be a few points to improve ;-)
@@ -781,6 +786,7 @@ COMMITTED: 'COMMITTED'; | |||
CONDITION: 'CONDITION'; | |||
CONDITIONAL: 'CONDITIONAL'; | |||
CONFIGNODES: 'CONFIGNODES'; | |||
AINODES: 'AINODES'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using lexicographical order here is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure ... quick fix ... I just always put it under the config node ... but didn't realize that list was alphabetically sorted.
Implemented the "show ainodes" command for the table model.