Bug 64142 - Use gray icons for disabled elements in the tree

[vlsi]

Description

a) Automatic generation of gray icons.
b) When an element is disabled, full subtree is rendered in gray. It does not impact execution, however, it makes it easier to understand what is disabled.

Screenshots (if appropriate):

https://recordit.co/Rz6E81R8hp

[pmouawad]

Hello @vlsi ,
It looks good to me.
How is the impact on performances of GUI ?

Regards
Philippe

[vlsi]

I guess it should not impact the performance much. If it becomes important, we could invent a fix.

[codecov-io]

Codecov Report

Merging #558 into master will decrease coverage by 0.01%.
The diff coverage is 3.7%.

@@             Coverage Diff             @@
##             master    #558      +/-   ##
===========================================
- Coverage     56.11%   56.1%   -0.02%     
- Complexity    10014   10017       +3     
===========================================
  Files          1024    1024              
  Lines         62897   62908      +11     
  Branches       7059    7067       +8     
===========================================
- Hits          35294   35293       -1     
- Misses        25133   25144      +11     
- Partials       2470    2471       +1

Impacted Files	Coverage Δ	Complexity Δ
.../org/apache/jmeter/gui/action/EnableComponent.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...n/java/org/apache/jmeter/plugin/PluginManager.java	12% <0%> (-4.67%)	2 <0> (ø)
...org/apache/jmeter/gui/tree/JMeterCellRenderer.java	46.42% <33.33%> (-1.58%)	4 <0> (+1)
.../jmeter/visualizers/RenderAsBoundaryExtractor.java	2.46% <0%> (-1.11%)	2% <0%> (ø)
.../org/apache/jmeter/visualizers/RenderAsRegexp.java	2.38% <0%> (-1.07%)	2% <0%> (ø)
...g/apache/jmeter/visualizers/RenderAsCssJQuery.java	1.86% <0%> (-0.86%)	2% <0%> (ø)
...a/org/apache/jmeter/visualizers/RenderAsXPath.java	5.94% <0%> (-0.8%)	3% <0%> (ø)
.../org/apache/jmeter/visualizers/RenderAsXPath2.java	3.52% <0%> (-0.65%)	3% <0%> (ø)
...n/java/org/apache/jmeter/reporters/Summariser.java	86.25% <0%> (+0.76%)	19% <0%> (+1%)	⬆️
...a/org/apache/jmeter/timers/PoissonRandomTimer.java	78.37% <0%> (+5.4%)	10% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a41b3...4d43735. Read the comment docs.

[vdaburon]

Hi,
A script is not a simple tree from Thread Group but a graph when you use a Module Controler.

In the Thread Group 1, somes samplers are enabled (001 and 015) and somes are disabled (006, 008 and 014), you could see with the gray color or not.
The Thread Group 2 with module controler use a module controler that go to the Thread Group 1 > Recording Controller.

When i disable the "Thread Group 1" all the children samplers look disabled (gray), i can't see witch samplers are "really" enabled or disabled.

The Module Controler from Thead Group2 with module controler will call samplers children of Recording Controller but now i can't see witch samplers will be really call because all samplers look disabled.

You need to enable samplers that will be call from the Module Controler path

Or add a jmeter.property to disabled this feature.

Regards.