Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump checksum-dependency-plugin to 1.86, so public pgp keys could be stored under the source control #5760

Merged
merged 1 commit into from
Jan 10, 2023
Merged

bump checksum-dependency-plugin to 1.86, so public pgp keys could be stored under the source control #5760

merged 1 commit into from
Jan 10, 2023

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Jan 10, 2023 •
edited
Loading

Fixes #5749

This commit brings PGP key caching under the source control, so building JMeter would no longer require receiving keys from the keyservers.

Note:

  • the stored PGP keys are shortened (e.g. signatures, and images are excluded)
  • checksum.xml enforces full key fingerprints for now, so it avoids short key collisions if any
  • short key is the last 8 bytes from the full fingerprint. For instance, old key 1c8d5ef0df2b70d4 becomes 07dbc3c1ab1f4468471656061c8d5ef0df2b70d4

@vlsi vlsi force-pushed the pgp branch 6 times, most recently from aee9e3b to 8889755 Compare January 10, 2023 18:01
@vlsi vlsi added this to the 5.5-next milestone Jan 10, 2023
@vlsi vlsi merged commit 237d283 into apache:master Jan 10, 2023
@vlsi vlsi deleted the pgp branch April 27, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.

jmeter build failed
1 participant
@vlsi