Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make allowed version of freemarker explicit #633

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

FSchumacher
Copy link
Contributor

Description

Make the compatible version of freemarker template engine explicit.

Motivation and Context

The freemarker docs state, that it is not allowed to use Config#getVersion()
directly, to specify the version, that we think we are compatible with.

Therefore, let us specify the current version and update it, as we update
the dependency or the templates.

How Has This Been Tested?

Ran ./gradlew build and grepped for getVersion in src/dist-check/jmeter.log and the following message is gone

$ grep -r Configuration.getVersion src/dist-check/jmeter.log
2020-11-03 16:20:29,732 ERROR f.configuration: DefaultObjectWrapper.incompatibleImprovements was set to the object returned by Configuration.getVersion(). That defeats the purpose of incompatibleImprovements, and makes upgrading FreeMarker a potentially breaking change. Also, this probably won't be allowed starting from 2.4.0. Instead, set incompatibleImprovements to the highest concrete version that's known to be compatible with your application.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

The freemarker docs state, that it is not allowed to use Config#getVersion()
directly, to specify the version, that we think we are compatible with.

Therefore, let us specify the current version and update it, as we update
the dependency or the templates.
@FSchumacher FSchumacher merged commit ac45fba into apache:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant