Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17554: Flaky testFutureCompletionOutsidePoll in ConsumerNetworkClientTest #17217

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

m1a2st
Copy link
Contributor

@m1a2st m1a2st commented Sep 17, 2024

Jira: https://issues.apache.org/jira/browse/KAFKA-17554
In the previous workflow, the test passes under two conditions:

  1. The t1 thread is waiting for the main thread's client.wakeup(). If successful, t1 will wake up t2, allowing t2 to complete the future.
  2. If t1 fails to receive the client.wakeup() from the main thread, t2 will be woken up by the main thread.
    The flaky test error occurs because neither t1 nor t2 are being properly woken up by the main thread. To resolve this, I suggest adjusting the test flow so that the main thread calls client.wakeup() before the t1 thread starts polling. Then, after t1 starts polling, the t2 thread can begin its poll. Additionally, I propose increasing the wait time in MockClient#maybeAwaitWakeup from 5 seconds to 10 seconds for better reliability.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant