KAFKA-17554: Flaky testFutureCompletionOutsidePoll in ConsumerNetworkClientTest #17217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-17554
In the previous workflow, the test passes under two conditions:
t1
thread is waiting for the main thread's client.wakeup(). If successful,t1
will wake upt2
, allowingt2
to complete the future.t1
fails to receive the client.wakeup() from the main thread,t2
will be woken up by the main thread.The flaky test error occurs because neither
t1
nort2
are being properly woken up by the main thread. To resolve this, I suggest adjusting the test flow so that the main thread calls client.wakeup() before the t1 thread starts polling. Then, aftert1
starts polling, thet2
thread can begin its poll. Additionally, I propose increasing the wait time inMockClient#maybeAwaitWakeup
from 5 seconds to 10 seconds for better reliability.Committer Checklist (excluded from commit message)