Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KARAF-6017] - added cache facade #1677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

awrb
Copy link
Contributor

@awrb awrb commented Oct 25, 2022

Draft phase (it works but it's not a proper component yet).

I'm opening a pr already so it can be reviewed before putting more work into it.

Some features:

  • it uses ehcache with JSR 107 API
  • the api does not depend on ehcache, so other providers could be added
  • possible to load ehcache configuration from xml
  • some karaf commands for debugging/playing around with the caches

Some open points:

@awrb
Copy link
Contributor Author

awrb commented Oct 25, 2022

@jbonofre would be great if you can take a look 😃 once we agree on the requirements then I'll start adding javadocs, tests, feature etc.

@jbonofre jbonofre self-requested a review October 26, 2022 12:02
@jbonofre jbonofre marked this pull request as draft October 26, 2022 12:02
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start. I will come back to you with more detailed feedback (busy at EclipseCon this week).

@awrb awrb force-pushed the KARAF-6017 branch 2 times, most recently from e06d478 to 14e9ca2 Compare November 21, 2022 20:24
@awrb
Copy link
Contributor Author

awrb commented Nov 21, 2022

@jbonofre I made a proper pull request now (added docs, example, tests etc). I'm happy to introduce any changes if needed.

@awrb awrb changed the title [DRAFT] [KARAF-6017] - added cache facade [KARAF-6017] - added cache facade Nov 21, 2022
@awrb awrb marked this pull request as ready for review November 24, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants