Tidy files inside src/commands #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit files according to clang-tidy tips. Narrowing conversion were left untouched.
torwig
commented
Nov 24, 2022
|
|
||
| if (*ttl_ms <= 0) return {Status::RedisParseErr, errInvalidExpireTime}; | ||
|
|
||
| if (*ttl_ms < 1000) { |
There was a problem hiding this comment.
Because the condition *ttl_ms <= 0 was checked a few lines before, here we can omit the *ttl_ms > 0 check.
git-hulk
approved these changes
Nov 24, 2022
PragmaTwice
approved these changes
Nov 24, 2022
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit files according to clang-tidy tips.
Found a few places with missed
returnkeywords.Fixed some typos.
Inserted blank lines to break the code into logical blocks.
Use
size_tinforloops.Uninitialized variables were initialized.
Condition statements
if (a == nullptr)andif (a != nullptr)were replaced withif (!a)andif (a)respectively.The occurrences of
rocksdb::Statuswere replaced withauto.Narrowing conversions were left untouched for now.
P.S. Diff is really big because the file
src/commands/redis_cmd.ccis big by itself.